The way we do code review is fluid and perpetually changing. I've updated my list of good code review practices to reflect this day.

TL;DR: Five important points in my blog.

💎 Get your code reviewed while it's hot. Don't waste time fiddling with pull requests and online tools.

💎 Work in bite-size batches and use micro-commits to make changes digestible.

💎 Invite the right people around for review (or the whole team).

💎 Don't control people, mentor them.

💎 Let go of your ego, and trust the code to be improved in the future.

@nikoheikkila I really need to learn how to manage git better to improve on the second point.
@Ninmi @nikoheikkila A key point is to became good enough at interactive rebasing that you can make frequent commits while working on the code and then relatively effortlessly rework it to a helpful narrative once you've reached your destination.

@clacke @Ninmi Yup, nowadays I mainly reword commit messages through interactive rebasing. Rarely I need to squash things together unless I've forgotten to add something (most of the time `git commit --amend --no-edit` is enough).

· · Web · 1 · 0 · 0
@nikoheikkila @Ninmi git config --global alias.amend 'commit --amend --no-edit'

git commit --fixup together with git rebase --autosquash is immensely useful too as a "retroactive amend".
Sign in to participate in the conversation
Mastodon for Tech Folks

This Mastodon instance is for people interested in technology. Discussions aren't limited to technology, because tech folks shouldn't be limited to technology either!